Skip to content

test: rename fixture config to default_config to avoid name conflict #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bearomorphism wants to merge 1 commit into from
Closed

test: rename fixture config to default_config to avoid name conflict #1836

bearomorphism wants to merge 1 commit into from
+405 −364

Conversation

@bearomorphism
Copy link
Collaborator

@bearomorphism bearomorphism commented Feb 1, 2026

No description provided.

@codecov
Copy link

codecov bot commented Feb 1, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.98%. Comparing base (26e5d80) to head (50ea789).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files          60       60           
  Lines        2686     2686           
=======================================
  Hits         2632     2632           
  Misses         54       54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bearomorphism bearomorphism marked this pull request as draft February 1, 2026 12:06
@bearomorphism bearomorphism changed the title test: remove duplicated fixture test: rename fixture config to default_config to avoid name conflict Feb 1, 2026
bearomorphism
bearomorphism commented Feb 1, 2026
View reviewed changes
tests/commands/conftest.py
Copy link
Collaborator Author

@bearomorphism bearomorphism Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated fixtures

@bearomorphism bearomorphism marked this pull request as ready for review February 1, 2026 13:09
noirbizarre
noirbizarre reviewed Feb 3, 2026
View reviewed changes
Copy link
Member

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just remove the duplicate config fixture in tests/commands/conftest.py is enough.
I find config more explicit and producing shorted line that default_config (for which I would expect a non-default config somewhere).
Plus, pytest fixture pattern philosophy push to reuse names to override fixture instead of multiplicating fixture, so I think it's best to just keep config

@bearomorphism
Copy link
Collaborator Author

bearomorphism commented Feb 3, 2026

Thanks for explanation, I didn't know the philosophy details behind pytest fixture.

The main motivation of this PR was that we have a module called config and a fixture also with that name. It sometimes confuses me. I guess there is a better solution like import config as cf in our tests.

Now I agree that we should keep the name unchanged.

@bearomorphism
Copy link
Collaborator Author

bearomorphism commented Feb 3, 2026

I will close this PR and make create another one for removing duplicated fixtures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noirbizarre noirbizarre noirbizarre left review comments

@woile woile Awaiting requested review from woile woile is a code owner

@Lee-W Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

Assignees

No one assigned

Labels

pr-status: wait-for-review type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bearomorphism @noirbizarre